Repository navigation
feat(@angular/cli): handle string key/value pairs, e.g. --define - #28362
Merged
Merged
Conversation
angular-robot
Bot
added
detected: feature
5 of 14 tasks
hybrist
marked this pull request as draft
September 6, 2024 18:41
Contributor
Author
|
Unfortunately it seems like this is currently still not properly triggering usage errors when invalid values are passed. Need to dig a bit more. |
alan-agius4
added
the
action: review
hybrist
marked this pull request as ready for review
September 6, 2024 18:59
alan-agius4
reviewed
Sep 6, 2024
alan-agius4
approved these changes
Sep 9, 2024
alan-agius4
left a comment
alan-agius4
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just a couple of NITs.
hybrist
force-pushed
the
define-flag
branch
4 times, most recently
from
September 9, 2024 17:08
9727ff8 to
7c1c955
Compare
alan-agius4
reviewed
Sep 9, 2024
alan-agius4
reviewed
Sep 9, 2024
alan-agius4
approved these changes
Sep 9, 2024
alan-agius4
left a comment
alan-agius4
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, two minor optional nits.
alan-agius4
added
action: merge
Contributor
Author
|
Thanks for the review! |
alan-agius4
approved these changes
Sep 9, 2024
hybrist
added a commit
to hybrist/angular-cli
that referenced
this pull request
Sep 11, 2024
We recently introduced the ability to pass object values from the command line (angular#28362). @clydin noticed that the initial behavior didn't work well for `--define`: It completely replaced all values even if just one of multiple defines is specified. This updates the architect to support merging of object options. If both the base option (e.g. from `angular.json`) and the override (e.g. from a CLI `--flag`) are objects, the objects are merged. See: angular#28362
2 of 13 tasks
alan-agius4
pushed a commit
that referenced
this pull request
Sep 12, 2024
We recently introduced the ability to pass object values from the command line (#28362). @clydin noticed that the initial behavior didn't work well for `--define`: It completely replaced all values even if just one of multiple defines is specified. This updates the architect to support merging of object options. If both the base option (e.g. from `angular.json`) and the override (e.g. from a CLI `--flag`) are objects, the objects are merged. See: #28362
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The values of
definecan only be updated by changing the Angular config file.Issue Number: #4318 (arguably)
What is the new behavior?
Defines can now be introduced or changed by passing them to the CLI, e.g.:
Does this PR introduce a breaking change?
Other information
The PR also moves
addSchemaOptionsToCommandto be colocated withparseJsonSchemaToOptions. The two functions are tightly coupled and it makes unit testing the schema-to-yargs flow a lot easier.